fix: handle errors due to open dialogs during tool calls#1953
Open
fix: handle errors due to open dialogs during tool calls#1953
Conversation
This change also adds a check for existence of open dialogs before trying to detect open devtools
OrKoN
reviewed
Apr 27, 2026
OrKoN
reviewed
Apr 27, 2026
OrKoN
approved these changes
Apr 27, 2026
Author
|
Added a test |
OrKoN
reviewed
Apr 28, 2026
| }); | ||
|
|
||
| const content = result.content as TextContent[]; | ||
| assert.match(content[0].text, /\[Blocked\] Action triggered a dialog\./); |
Collaborator
There was a problem hiding this comment.
could we assert complete response via a snapshot assertion? I want to make sure there is no duplication in the full response
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is part of the fix for #1069