chore(memory): sort all by retainer size#1963
Open
Lightning00Blade wants to merge 5 commits intomainfrom
Open
Conversation
Lightning00Blade
changed the title
Lightning00Blade
force-pushed
the
sort-nodes
branch
from
f0f7597 to
57e713c
Compare
OrKoN
reviewed
Apr 28, 2026
| @@ -1,31 +1,4 @@ | |||
| exports[`THIRD_PARTY_NOTICES > matches snapshot if exists 1`] = ` | |||
| Name: urlpattern-polyfill | |||
Collaborator
There was a problem hiding this comment.
I think you need to revert this change
OrKoN
reviewed
Apr 28, 2026
|
|
||
| #getSortedAggregates(): AggregatedInfoWithUid[] { | ||
| return Object.values(this.#aggregates).sort((a, b) => b.self - a.self); | ||
| return Object.values(this.#aggregates).sort((a, b) => b.maxRet - a.maxRet); |
Collaborator
There was a problem hiding this comment.
can we re-use any code from the dtf to handle the various sorting and lookups?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a better measurement as if object self size is X and the retainerSize Y. X will always be smaller then Y, there Y will be the actual size on the Heap.