tests(react): improve webchat tests#1066
Merged
AinaVendrell merged 1 commit intomasterfrom Nov 9, 2020
Merged
Conversation
AinaVendrell
requested review from
dpinol,
elozano98,
ericmarcos and
vanbasten17
vanbasten17
approved these changes
Nov 6, 2020
Contributor
vanbasten17
left a comment
vanbasten17
left a comment
There was a problem hiding this comment.
Looking good Aina, good work! 👏 Can you please rename tests literals to contain 'TEST:' ?
elozano98
reviewed
Nov 6, 2020
elozano98
approved these changes
Nov 6, 2020
Contributor
elozano98
left a comment
elozano98
left a comment
There was a problem hiding this comment.
Good job with these test improvements! 👏 💯
vanbasten17
requested changes
Nov 6, 2020
AinaVendrell
force-pushed
the
feat/improve-webchat-tests
branch
from
af0c8b7 to
6976f4f
Compare
dpinol
approved these changes
Nov 7, 2020
| return file | ||
| } | ||
|
|
||
| export function expectToHaveRoles(role, screen) { |
| }) | ||
| } | ||
|
|
||
| export function expectNotToHaveRoles(role, screen) { |
AinaVendrell
force-pushed
the
feat/improve-webchat-tests
branch
from
037252b to
0cb49fb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
persistentMenutestexpectToHaveRolesandexpectNotToHaveRolesto extract the common logic of the testsContext
PersistentMenutest was failing because thecloseLabelbutton has no payload, path, webviews or urlApproach taken / Explain the design
To solve the
PersistentMenuerror, check if the button hasonClickpropTo document / Usage example
Testing
The pull request...